MobileMenu.checkWindowSize - Code Metrics - Inspection of "Merge pull request #236 from GCTC-NTGC/forms_appli..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 401bbc...02c732 )

by Grant

created 2018-06-27 17:24 UTC

MobileMenu.checkWindowSize A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
nc	3
nop	0
dl	0
loc	1
rs	10
c	1
b	0
f	0


var MobileMenu = {};

MobileMenu.debug = true;

if (!window.console) {
    var console = {};
}

if (!console.log) {

    console.log = function () {};
}

// Window Event Listener =======================================================

MobileMenu.addWindowEventListener = function (event, myFunction) {

    if (window.addEventListener) {

        window.addEventListener(event, myFunction, false);

    } else if (window.attachEvent) {

        var onEvent = "on" + event;

        window.attachEvent(onEvent, myFunction);

    }

};

// Window Size Check for TabIndex ==============================================

MobileMenu.checkWindowSize = function() {

    var x = window.matchMedia("screen and (min-width: 1024px)");

    if (x.matches) {

        var mainMenu = document.getElementById("pageHeroNavigationMenu");

        var menuItems = mainMenu.querySelectorAll(".page-hero__navigation-item a");

        for (var i = 0; i < menuItems.length; i++) {

            menuItems[i].setAttribute("tabindex", "0");

        }

    }

}


MobileMenu.addWindowEventListener("load", MobileMenu.checkWindowSize);

// Mobile Navigation Triggers ==================================================

MobileMenu.mobileNavClickListener = function (e) {

    var mobileMenuTrigger = document.getElementById("pageHeroMobileTrigger");


    var mainMenu = document.getElementById("pageHeroNavigationMenu");

    var menuItems = mainMenu.querySelectorAll(".page-hero__navigation-item a");

    e.preventDefault();

    if (this.classList.contains("active")) {

        this.classList.remove("active");

        mainMenu.classList.remove("active");

        for (var i = 0; i < menuItems.length; i++) {

            menuItems[i].setAttribute("tabindex", "-1");

        }

        document.body.style.overflowY = "visible";

    } else {

        this.classList.add("active");

        mainMenu.classList.add("active");

        for (var i = 0; i < menuItems.length; i++) {


            menuItems[i].setAttribute("tabindex", "0");

        }

        document.body.style.overflowY = "hidden";

    }

};

MobileMenu.mobileNavKeyListener = function (e) {

    if (e.keyCode == 13) {

        this.click();

    }

};

MobileMenu.setMobileNavTriggers = function () {

    // Gets all elements on the page with "accordion-trigger".
    var mobileMenuTrigger = document.getElementById("pageHeroMobileTrigger");

    // Checks for a click.
    mobileMenuTrigger.addEventListener("click", MobileMenu.mobileNavClickListener);

    // Checks for an Enter key click.
    mobileMenuTrigger.addEventListener("keydown", MobileMenu.mobileNavKeyListener);

};

MobileMenu.addWindowEventListener("load", MobileMenu.setMobileNavTriggers);

// Mobile Navigation Tab Order =================================================

MobileMenu.mobileNavTabListener = function (e) {

    // Get the Main Menu
    var mainMenu = document.getElementById("pageHeroNavigationMenu");

    // Get Mobile Menu Trigger
    var menuTrigger = document.querySelector(".page-hero__mobile-trigger");

    // Get Mobile Menu Items
    var menuItems = mainMenu.querySelectorAll(".page-hero__navigation-item:not(.hidden) a");

    // Get Last Menu Item
    var lastMenuItem = menuItems[menuItems.length - 1]


    if (e.keyCode == 9) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined

        if (this === lastMenuItem) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined

            e.preventDefault();

            menuTrigger.focus();

            return false;

        }

    }

}


MobileMenu.setMobileNavTabTriggers = function (e) {


    var x = window.matchMedia("screen and (max-width: 1023px)");

    if (x.matches) {

        // Get the Main Menu
        var mainMenu = document.getElementById("pageHeroNavigationMenu");

        // Get Mobile Menu Items
        var menuItems = mainMenu.querySelectorAll(".page-hero__navigation-item a");

        // Set Triggers
        for (var i = 0; i < menuItems.length; i++) {

            menuItems[i].addEventListener("keydown", MobileMenu.mobileNavTabListener);

        }

    }

}


MobileMenu.addWindowEventListener("load", MobileMenu.setMobileNavTabTriggers);

1
2			var MobileMenu = {};
3
4			MobileMenu.debug = true;
5
6			if (!window.console) {
7			var console = {};
8			}
9
10			if (!console.log) {
			0 ignored issues – show Bug introduced 2018-06-14 18:50 UTC by Report Bug Copy Issue Report The variable `console` does not seem to be initialized in case `!window.console` on line `6` is `false`. Are you sure this can never be the case? Loading history...
11			console.log = function () {};
12			}
13
14			// Window Event Listener =======================================================
15
16			MobileMenu.addWindowEventListener = function (event, myFunction) {
17
18			if (window.addEventListener) {
19
20			window.addEventListener(event, myFunction, false);
21
22			} else if (window.attachEvent) {
23
24			var onEvent = "on" + event;
25
26			window.attachEvent(onEvent, myFunction);
27
28			}
29
30			};
31
32			// Window Size Check for TabIndex ==============================================
33
34			MobileMenu.checkWindowSize = function() {
35
36			var x = window.matchMedia("screen and (min-width: 1024px)");
37
38			if (x.matches) {
39
40			var mainMenu = document.getElementById("pageHeroNavigationMenu");
41
42			var menuItems = mainMenu.querySelectorAll(".page-hero__navigation-item a");
43
44			for (var i = 0; i < menuItems.length; i++) {
45
46			menuItems[i].setAttribute("tabindex", "0");
47
48			}
49
50			}
51
52			}
			0 ignored issues – show Coding Style introduced 2018-06-27 17:26 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
53
54			MobileMenu.addWindowEventListener("load", MobileMenu.checkWindowSize);
55
56			// Mobile Navigation Triggers ==================================================
57
58			MobileMenu.mobileNavClickListener = function (e) {
59
60			var mobileMenuTrigger = document.getElementById("pageHeroMobileTrigger");
			0 ignored issues – show Unused Code introduced 2018-06-14 18:50 UTC by Report Bug Copy Issue Report The variable `mobileMenuTrigger` seems to be never used. Consider removing it. Loading history...
61
62			var mainMenu = document.getElementById("pageHeroNavigationMenu");
63
64			var menuItems = mainMenu.querySelectorAll(".page-hero__navigation-item a");
65
66			e.preventDefault();
67
68			if (this.classList.contains("active")) {
69
70			this.classList.remove("active");
71
72			mainMenu.classList.remove("active");
73
74			for (var i = 0; i < menuItems.length; i++) {
75
76			menuItems[i].setAttribute("tabindex", "-1");
77
78			}
79
80			document.body.style.overflowY = "visible";
81
82			} else {
83
84			this.classList.add("active");
85
86			mainMenu.classList.add("active");
87
88			for (var i = 0; i < menuItems.length; i++) {
			0 ignored issues – show Comprehensibility Naming Best Practice introduced 2018-06-27 17:26 UTC by Report Bug Copy Issue Report The variable `i` already seems to be declared on line `74`. Consider using another variable name or omitting the `var` keyword. This check looks for variables that are declared in multiple lines. There may be several reasons for this. In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs. If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared. Loading history... Bug introduced 2018-06-27 17:26 UTC by Report Bug Copy Issue Report It seems like `i` was already defined. Loading history...
89
90			menuItems[i].setAttribute("tabindex", "0");
91
92			}
93
94			document.body.style.overflowY = "hidden";
95
96			}
97
98			};
99
100			MobileMenu.mobileNavKeyListener = function (e) {
101
102			if (e.keyCode == 13) {
103
104			this.click();
105
106			}
107
108			};
109
110			MobileMenu.setMobileNavTriggers = function () {
111
112			// Gets all elements on the page with "accordion-trigger".
113			var mobileMenuTrigger = document.getElementById("pageHeroMobileTrigger");
114
115			// Checks for a click.
116			mobileMenuTrigger.addEventListener("click", MobileMenu.mobileNavClickListener);
117
118			// Checks for an Enter key click.
119			mobileMenuTrigger.addEventListener("keydown", MobileMenu.mobileNavKeyListener);
120
121			};
122
123			MobileMenu.addWindowEventListener("load", MobileMenu.setMobileNavTriggers);
124
125			// Mobile Navigation Tab Order =================================================
126
127			MobileMenu.mobileNavTabListener = function (e) {
128
129			// Get the Main Menu
130			var mainMenu = document.getElementById("pageHeroNavigationMenu");
131
132			// Get Mobile Menu Trigger
133			var menuTrigger = document.querySelector(".page-hero__mobile-trigger");
134
135			// Get Mobile Menu Items
136			var menuItems = mainMenu.querySelectorAll(".page-hero__navigation-item:not(.hidden) a");
137
138			// Get Last Menu Item
139			var lastMenuItem = menuItems[menuItems.length - 1]
			0 ignored issues – show Coding Style introduced 2018-06-14 18:50 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
140
141			if (e.keyCode == 9) {
			0 ignored issues – show Complexity Best Practice introduced 2018-06-14 18:50 UTC by Report Bug Copy Issue Report There is no return statement if `e.keyCode == 9` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
142
143			if (this === lastMenuItem) {
			0 ignored issues – show Complexity Best Practice introduced 2018-06-14 18:50 UTC by Report Bug Copy Issue Report There is no return statement if `this === lastMenuItem` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
144
145			e.preventDefault();
146
147			menuTrigger.focus();
148
149			return false;
150
151			}
152
153			}
154
155			}
			0 ignored issues – show Coding Style introduced 2018-06-14 18:50 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
156
157			MobileMenu.setMobileNavTabTriggers = function (e) {
			0 ignored issues – show Unused Code introduced 2018-06-14 18:50 UTC by Report Bug Copy Issue Report The parameter `e` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
158
159			var x = window.matchMedia("screen and (max-width: 1023px)");
160
161			if (x.matches) {
162
163			// Get the Main Menu
164			var mainMenu = document.getElementById("pageHeroNavigationMenu");
165
166			// Get Mobile Menu Items
167			var menuItems = mainMenu.querySelectorAll(".page-hero__navigation-item a");
168
169			// Set Triggers
170			for (var i = 0; i < menuItems.length; i++) {
171
172			menuItems[i].addEventListener("keydown", MobileMenu.mobileNavTabListener);
173
174			}
175
176			}
177
178			}
			0 ignored issues – show Coding Style introduced 2018-06-14 18:50 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
179
180			MobileMenu.addWindowEventListener("load", MobileMenu.setMobileNavTabTriggers);

GCTC-NTGC / TalentCloud

Push — master ( 401bbc...02c732 )

MobileMenu.checkWindowSize A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like